Extend component #185
Merged
Extend component #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was thinking of options to set and get SPICE parameters in a way that is less manual than directly writing the text labels only. So I thought of extending the Component class to allow to do so. This is with reference to the discussion # 249 in the EBeam PDK (SiEPIC/SiEPIC_EBeam_PDK#249). The get method here basically is just a wrapper of the params property, but the set method checks if there is a Text cell with the SPICE parameters, changes that text and updates the component.param property. If no TextCell is found, then it just creates one. If this function is called outside of a PCell declaration itself, then whatever it's done is basically replaced or erased by the original cell information when it gets re-instantiated, so it would only be permanent on static cells. Still, I think it would be a useful method to for example update the waveguide parameters in the Waveguide PCell (usually this is defined in the PDK, but the SPICE parameters are defined inside the SiEPIC.utils layout calls). This shouldn't have any compatibility issues since they are new methods. Although I did add a semicolon erasing to the params_dict method.
fix pdic2str to follow SPICE format specifications and always adds a quotes on the parameters names, to allow for labels with spaces.
…PIC-Tools into extend_component
Update to not always put double quotes in the parameters naming
fix other 'dcsource' labels to 'dc source' and changed the SPICE component name to replace space characters to '_' only if the component model is **not** put in double quotes.
Update to use 'u' for small numbers in the SPICE params string
jevillegasd
commented
Mar 21, 2023
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in SPICE netlist generation and SPICE parameters handling.