-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: Automatic finding of USB binds based on instrument IDN #210
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 32.67% 32.23% -0.45%
==========================================
Files 85 86 +1
Lines 5800 5873 +73
==========================================
- Hits 1895 1893 -2
- Misses 3905 3980 +75 ☔ View full report in Codecov by Sentry. |
Please rebase to check if pipeline is now working. |
* PRJ: Update workflow (verilog version, python version) --------- Co-authored-by: Yannick Dieter <yannick.manuel.dieter@cern.ch> Co-authored-by: Christian Bespin <11457592+cbespin@users.noreply.github.com> Co-authored-by: Christian Bespin <silab@debian-BULLSEYE-live-builder-AMD64>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature will be very useful! I like to keep the amount of required packages as low as possible, but I see no alternative to ruamel.yaml here.
When the function names are changed to something more pythonic, I will approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks! The discussion about required packages will be moved to #188
Implemented
findUSBBinds()
to find the Linux USB binds based on given IDN in the configuration file. Withmodify_basil_config()
one can then automatically update the ports/resource_names of the transfer layers (serial/visa).For this to work the transfer layer needs an additional init parameter (
identification
). Like in this example, whereresource_name
is automatically updated to the current USB bind after executingmodify_basil_config()
.