-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installation + Python3 compability #9
base: development
Are you sure you want to change the base?
Conversation
In principle, unit tests are working (I tested this locally), but due to the fact that pybar is needed for the data replay feature, unit test will fail since pybar is not installed. I guess we need to add pybar to the dependencies...? @DavidLP |
No, pybar is too much of a dependency. We actually once decided to abandon this repository, that is just a collection for our DAQs online-monitor plugings and decided that the plugin should be defined in the DAQ repository itself. This is e.g. done in bdaq. |
If you want to have the telescope plugins collected here, one could rename it to testbeam_online_monitor. |
Okay fine for me. I defined already the needed plugins in pymosa, including a new generic hit correlator. Then we do not move the hit correlator plugin to this repository, instead we leave it in pymosa, okay? I guess this is also reasonable since you only want to correlate DUTs when you are using a telescope. In order to be consistent, we should move then the pybar plugins to pybar, no? |
Adding to this discussion: I think this repo should be archived as the general approach should be to define online monitor plugins |
Also @YannickDieter I agree, pybar plugins should go to pybar |
This PR fixes python3 compability and fixes the installation procedures in travis.