Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation + Python3 compability #9

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Conversation

YannickDieter
Copy link

This PR fixes python3 compability and fixes the installation procedures in travis.

@YannickDieter YannickDieter changed the base branch from master to development March 30, 2020 15:22
@YannickDieter YannickDieter requested a review from DavidLP March 30, 2020 15:22
@YannickDieter
Copy link
Author

In principle, unit tests are working (I tested this locally), but due to the fact that pybar is needed for the data replay feature, unit test will fail since pybar is not installed.

I guess we need to add pybar to the dependencies...? @DavidLP

@DavidLP
Copy link
Collaborator

DavidLP commented Mar 30, 2020

No, pybar is too much of a dependency. We actually once decided to abandon this repository, that is just a collection for our DAQs online-monitor plugings and decided that the plugin should be defined in the DAQ repository itself. This is e.g. done in bdaq.

@DavidLP
Copy link
Collaborator

DavidLP commented Mar 30, 2020

If you want to have the telescope plugins collected here, one could rename it to testbeam_online_monitor.
The cleanest implementation of the data sending is here. You just have to define the send function and it would work stand alone on most our data (bdaq, pybar).

@YannickDieter
Copy link
Author

Okay fine for me. I defined already the needed plugins in pymosa, including a new generic hit correlator.

Then we do not move the hit correlator plugin to this repository, instead we leave it in pymosa, okay? I guess this is also reasonable since you only want to correlate DUTs when you are using a telescope.

In order to be consistent, we should move then the pybar plugins to pybar, no?

@leloup314
Copy link
Member

leloup314 commented Nov 4, 2022

Adding to this discussion: I think this repo should be archived as the general approach should be to define online monitor plugins
on the DAQ level as proposed buy @DavidLP. If this is okay i will update the readme as such @YannickDieter

@leloup314
Copy link
Member

Also @YannickDieter I agree, pybar plugins should go to pybar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants