-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add corryvreckan converter script #41
Conversation
Thanks for the script! I was not able to testshi script, because after interpretation, i don't have a table 'Hits'. I only have a table 'Dut'. Also the Dut table does not have the TLU words associated with the hits yet. I had to do this by meself in my QnD converter script. |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in the eudet mode with my custom event builder.
However when i try to use the event builder from the repo, there is an issue:
2024-12-17 12:13:29,053 [Analysis ] - ERROR Exception during analysis
Traceback (most recent call last):
File "/mnt/Daten/Nosync/Schule/tj-monopix2-daq/tjmonopix2/analysis/corryvreckan_converter.py", line 93, in <module>
a.analyze_data()
File "/mnt/Daten/Nosync/Schule/tj-monopix2-daq/tjmonopix2/analysis/analysis.py", line 379, in analyze_data
hist_cs_tot += cs_tot.astype(np.uint32)
ValueError: operands could not be broadcast together with shapes (256,) (512,) (256,)
Traceback (most recent call last):
File "/mnt/Daten/Nosync/Schule/tj-monopix2-daq/tjmonopix2/analysis/corryvreckan_converter.py", line 93, in <module>
a.analyze_data()
File "/mnt/Daten/Nosync/Schule/tj-monopix2-daq/tjmonopix2/analysis/analysis.py", line 379, in analyze_data
hist_cs_tot += cs_tot.astype(np.uint32)
ValueError: operands could not be broadcast together with shapes (256,) (512,) (256,)
0%|
I am not 100% sure if the repo event builder fails because my data format is different or if this is a general issue and noone used it so far...
The feature has been used / is used all the time, it originates from the clusterizer that is integrated for standalone analysis. What is your TOT binning? Did you apply a charge conversion already at some point? Otherwise it might be your data format |
If i use my custom event builder it works fine. But if i just let the script interpret the h5 file we have, it fails. But my data file uses the TLU-format with only trigger number, so i guess that's why it is failing. the results would be useless anyway and that's the reason i have my custom event bulder. |
I guess that will be the case since the clusterizer works on event basis in this case which is not really possible with the data format you have available. I will fix the column and row numbering, would you approve the PR then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now! Thanks!
Adds a standalone script to convert interpreted data to a format compatible with the corryvreckan EventLoaderHDF5. Supports:
@maxbab1 Please have a look if you spot any mistakes