Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle version number set at project level #99

Merged

Conversation

paynerc
Copy link
Contributor

@paynerc paynerc commented Sep 5, 2024

While setting up fastlane for a work project I ran into an issue because we set our version number at the project level. I noticed that two issues were raised that seem to be related, #72 and #98.

For retrieving version number, if the target or scheme is not provided, it will first attempt to get the version from the project level. If one is not defined, it defaults back to the original methodology and if there is more than one scheme, it will prompt you to select one.

For setting the version number, if it is determined that the version is set at the project level, it will update it there, otherwise it is business as usual.

@jdouglas-nz
Copy link
Collaborator

thank you for the contribution @paynerc ! and apologies for the delay in getting around to this. all looks good to me, tests all pass, will merge then ship.

@jdouglas-nz jdouglas-nz merged commit fbede4c into SiarheiFedartsou:master Nov 5, 2024
@letrongh
Copy link

Hello,

With version 0.7.0 and your fix, my version number was not updated anymore because I have set it at target level. So, I have just removed at target and set only at project level and it works great.

In my case it's ok but if you need to set at target level, the plugin will write the version at project + target, and next time, it will only change at project level. Or I have missed something?

Thanks

@paynerc
Copy link
Contributor Author

paynerc commented Nov 22, 2024

To continue to do target versioning you just have to specify the target you want to update with the options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants