Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding T411.si as a torrent provider #4050

Closed
wants to merge 9 commits into from
Closed

Adding T411.si as a torrent provider #4050

wants to merge 9 commits into from

Conversation

jaytonic
Copy link

Fixes #4021

Proposed changes in this pull request:

  • Adding T411.SI as provider

It's my first contribution to SickRage, so if I did something wrong, please let me know and I will do my best to make it right.

I based my code on another tracker that also doesn't require any auth(cpasbien).

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read contribution guide

@jaytonic
Copy link
Author

Is there somebody that could validate this pull request?

@Sylanorr
Copy link

+1 ... Please validate this pull request :)

Thanks

@miigotu
Copy link
Contributor

miigotu commented Sep 27, 2017

@jaytonic
Copy link
Author

@miigotu It's not clear for me what is not working, could you maybe just point me in the right direction? I did my best but without documentation it's not very clear for me.

Because this test seems to be ignored for other providers
"Test is programmatically disabled for provider LimeTorrents"

@miigotu
Copy link
Contributor

miigotu commented Sep 29, 2017

The link I commented shows you, that your order of imports is out of order. follow the + and - in that link.

@codecov
Copy link

codecov bot commented Sep 29, 2017

Codecov Report

Merging #4050 into develop will increase coverage by 0.119%.
The diff coverage is 87.096%.

@@              Coverage Diff              @@
##           develop     #4050       +/-   ##
=============================================
+ Coverage   30.958%   31.078%   +0.119%     
=============================================
  Files          195       196        +1     
  Lines        29013     29075       +62     
=============================================
+ Hits          8982      9036       +54     
- Misses       20031     20039        +8
Impacted Files Coverage Δ
sickbeard/providers/__init__.py 31.372% <ø> (ø) ⬆️
sickbeard/providers/t411si.py 87.096% <87.096%> (ø)

@lejudoka13
Copy link

nice let's grab this to devellop branch @miigotu

Copy link

@lejudoka13 lejudoka13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me i tested it

@Asfalt-FR
Copy link

Bonjour je suis demandeur pour T411.si et yggtorent, y a t'il du nouveau ?

@adaur adaur closed this Nov 1, 2017
@jaytonic
Copy link
Author

jaytonic commented Nov 1, 2017

@adaur why did you close my pull request? Close it if it get merged or rejected...

@adaur
Copy link
Contributor

adaur commented Nov 1, 2017

T411.si is dead and has been merged with yggtorrent

@Sylanorr
Copy link

Sylanorr commented Nov 1, 2017 via email

@miigotu
Copy link
Contributor

miigotu commented Nov 8, 2017

Don't promote here, Thanks.

@SickChill SickChill deleted a comment from jaytonic Nov 8, 2017
@SickChill SickChill deleted a comment from adaur Nov 8, 2017
@SickChill SickChill deleted a comment from adaur Nov 8, 2017
@SickChill SickChill deleted a comment from jaytonic Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants