Conversation
hyotatoFrappuccino
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved Issue
PR Description
User 엔티티 필드 추가
isDeleted필드를 추가했습니다.enum으로 관리할 필요성을 못느껴 저장 공간과 쿼리 성능을 위해boolean을 사용했습니다.deletedDate필드를 추가했습니다.Time인터페이스 생성LocalDateTime.now()를 매개변수로 넘겨주도록 구현했었습니다. 그런데 이 방식은 Controller 계층이 아직 테스트하기 어렵다는 문제가 있고, 매개변수를 계속 넘겨줘야 하는 번거로움이 있습니다.테스트 픽스처 메서드 생성
UserRole이 고정되는 등 유연성이 떨어졌습니다.@Builder를 열어줘야 하는데,access = AccessLevel.PACKAGE로 접근 제한을 최소화했습니다.Others