Fix exception when price checking corrupted gems

[Ati1707]

This part of the parser does not work or I don't seem to grasp the functionality of this.

Sidekick/src/Sidekick.Apis.Poe/Parser/Metadata/MetadataParser.cs

Lines 55 to 59 in 9c4be79

	var canBeVaalGem = itemRarity == Rarity.Gem && parsingItem.Blocks.Count > 7;
	if (canBeVaalGem && data.NameAndTypeDictionary.TryGetValue(parsingItem.Blocks[5].Lines[0].Text, out var vaalGem))
	{
	return vaalGem.First();
	}

It tries to parse an empty line which creates the error since there is no text.

The parser already gets the corrupted state from the property parse I didnt go through the code but I assume that property is used to set the variable for the price check page as well.

data.NameAndTypeDictionary.TryGetValue(parsingItem.Blocks[5].Lines[0].Text
Even if that empty block would not be there it would still parse the wrong text.
Thats why I removed the vaal gem part from the code.

These are the blocks from zero to last element as you can see [] would be the sixth element even if that element would not be there it would parse Skills can be managed in the Skills Panel.

The gem text was taken from the mentioned issue:

[Item Class: Skill Gems, Rarity: Gem, Explosive Shot]
[Attack, AoE, Ammunition, Projectile, Fire, Detonator, Level: 16 (augmented), 15 Levels from Gem...]
[Requirements:, Level: 64, Crossbow, Str: 80, Dex: 80]
[Sockets: G G G ]
[...]
[]
[Skills can be managed in the Skills Panel.]
[Corrupted]

Closes #384

[domialex]

@leMicin This was for poe1 vaal gems?

[leMicin]

Yes this was a PoE1 condition.

@Ati1707 I believe the unit tests caught it failing. You should be able to exclude this vaal check by wrapping the whole block with something like item.Metadata.Game == PathOfExile condition.

[Ati1707]

Yes this was a PoE1 condition.

@Ati1707 I believe the unit tests caught it failing. You should be able to exclude this vaal check by wrapping the whole block with something like item.Metadata.Game == PathOfExile condition.

Thanks. I was testing poe1 gems yesterday as well but it was late and apparently I made a mistake because I got an error yesterday.
In that scope it doesn't have access to the metadata so I decided to instead check if lines in the sixth block exists because they dont exist in poe2 but do in poe1.
I tried a corrupted,non corrupted poe2 gem and corrupted, vaal corrupted poe1 gem. They all went through without any issues and the tests passed as well locally.