This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
Skip download if the user didn't select a dir, fix StorageList's checkboxes #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed https://dev.siderus.team/issues/108 (Cannot read property '0' of undefined)
While working on this I found 2 more bugs, one of which I fixed:
When I select a second element,
this.props.storageStore.selected.length
is actually 0, because the equality check fails (it thinks it's the same element), therefore clicking 'Download' after checking 2 items did nothing.(not fixed) When downloading more than 1 item, the loading wheel never disappears even though the files were saved. I dug a bit into this and it looks like when we call
saveFileToPath
twice, the promise resolves only once. My fear is that we can't useIPFS_CLIENT.files.getReadableStream(hash)
concurrently ... thoughts?