This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
Add option to disable the tray icon #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koalalorenzo
suggested changes
May 15, 2018
app/index.js
Outdated
|
|
||
| const systemTrayNotification = Settings.getSync('systemTrayNotification') | ||
|
|
||
| if (!systemTrayNotification) { |
There was a problem hiding this comment.
This will trigger the message every time the settings is false, try with a more specific setup:
systemTrayNotification === undefined
| * Repository Panel | ||
| */ | ||
| @observer | ||
| class AppPanel extends React.Component { |
There was a problem hiding this comment.
Do we really need a new panel for one option? Can we add it to the Daemon settings?
There was a problem hiding this comment.
I've added it to the connectivity panel, we don't have a daemon panel anymore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?