Add option to publish to IPNS #117
Conversation
app/menu.js
Outdated
| @@ -22,6 +23,12 @@ const template = [{ | |||
| click () { | |||
| ResolveIPNS.create(app) | |||
| } | |||
| }, { | |||
| label: 'PublishToIPNS', | |||
| accelerator: 'CmdOrCtrl+F', | |||
There was a problem hiding this comment.
I would invert Resolve (aka Find) and Publish:
- CmdOrCTRL+F => Resolve
- CmdOrCTRL+E => Publush
Does it make more sense? otherwise lets find something else. CMD+P? (used for Print, but what do we have to print? :P )
app/menu.js
Outdated
| @@ -22,6 +23,12 @@ const template = [{ | |||
| click () { | |||
| ResolveIPNS.create(app) | |||
| } | |||
| }, { | |||
| label: 'PublishToIPNS', | |||
There was a problem hiding this comment.
Add spaces, Publish to IPNS
| type="text" | ||
| placeholder="what would you like to publish?" | ||
| /> | ||
| </Content> |
There was a problem hiding this comment.
What if we add a line that is saying that this process may take few minutes?
| label="Your peer ID" | ||
| type="text" | ||
| value={peer ? peer.id : 'Loading...'} | ||
| readOnly |
There was a problem hiding this comment.
For some reason I cannot copy this. Should we add a button to copy the ID in the clipboard?
(Same issue goes in the settings)
| publishToIPNS(hash) | ||
| .then(result => { | ||
| this.setState({ loading: false }) | ||
| const message = `Successfully published ${result.value} to IPNS!` |
There was a problem hiding this comment.
Should we add the IPNS hash instead?
Something like IPNS ${peer id} has been successfully updated to ${result.value}?
|
I have spent my last 30 min trying to understand what is wrong here:
:O |
|
That's the error we get from ipfs when the hash is an empty string, not very nice... |
What changed?
Added Publish to IPNS window and Publish to IPNS to the StorageElement's menu.