This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
Fix "run garbage collector" button #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koalalorenzo
suggested changes
Jun 8, 2018
|
|
||
| _handelOnSubit (event) { | ||
|
|
||
| .then(() => this.props.informationStore.loadData()) |
There was a problem hiding this comment.
Are you sure this line is correct? why not:
.then(this.props.informationStore.loadData)
koalalorenzo
approved these changes
Jun 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed bug 161 and it's related sentry issues.
The problem was how we called the
loadDatafunction, if it's not wrapped under an arrow function,thisis evaluated toundefined.Also fixed the refreshing: because the button is by default of type submit it caused the form to be submitted and the window to be reloaded.