This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
Shows the activity window when adding a new file #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernelwhisperer
changed the title
|
ready for review :) |
koalalorenzo
changed the title
koalalorenzo
suggested changes
Jun 30, 2018
app/api.js
Outdated
| const filename = parse(path).base | ||
| const uuid = uuidv4() | ||
|
|
||
| if (size >= ACTIVITIES_WINDOW_THRESHOLD) { |
There was a problem hiding this comment.
can we add few lines of comments to describe why/what?
app/api.js
Outdated
| app.emit('show-activities-window') | ||
| } | ||
|
|
||
| const options = { |
app/index.js
Outdated
| @@ -286,6 +292,44 @@ app.on('start-orion', () => { | |||
| startWelcome().then(startOrion) | |||
| }) | |||
|
|
|||
| app.on('show-activities-window', () => { | |||
…erus/Orion into bugfix/157-progress-bar-while-adding
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added the activities window.
This is a WIP, but please take a look before I continue in this direction.