This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
fix import from hash dialog #145
Merged
kernelwhisperer
merged 6 commits into
master
from
bugfix/import-from-hash-peers-not-loading
Jul 4, 2018
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ad7f2fc
fix import from hash dialog
kernelwhisperer 3048b9c
remove comment
kernelwhisperer 9088022
fix import from hash -> stats store -> check
kernelwhisperer 62e7ddf
Merge branch 'master' into bugfix/import-from-hash-peers-not-loading
kernelwhisperer 8d687bd
Revert "fix import from hash -> stats store -> check"
kernelwhisperer c4eb2f9
Merge branch 'master' into bugfix/import-from-hash-peers-not-loading
kernelwhisperer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
import { observable } from 'mobx' | ||
import { remote } from 'electron' | ||
|
||
import { getObjectStat, getPeersWithObjectbyHash } from '../../../api' | ||
|
||
/** | ||
* StatStorage will contain the status and few information about the Object. | ||
|
@@ -31,6 +34,33 @@ export class StatStorage { | |
this.isLoading = false | ||
this.wasLoading = false | ||
this.importing = false | ||
this.wasLoadingStats = false | ||
} | ||
|
||
check () { | ||
// Prepare the promise to check the Peers | ||
const pPeers = getPeersWithObjectbyHash(this.hash) | ||
.then(peers => { | ||
console.log('got peers', peers) | ||
this.peersAmount = peers.length | ||
this.isLoading = false | ||
}) | ||
|
||
// Prepare the promise to check the stats | ||
const pStats = getObjectStat(this.hash) | ||
.then(stats => { | ||
console.log('got stats') | ||
this.stats = stats | ||
this.isLoading = false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about concurrency? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree, better to handle them in |
||
}) | ||
|
||
this.isLoading = true | ||
this.wasLoadingStats = true | ||
return Promise.all([pPeers, pStats]) | ||
.catch(err => { | ||
this.isLoading = false | ||
remote.dialog.showErrorBox('Gurl, an error occurred', `${err}`) | ||
}) | ||
} | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a catch here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The catch is in the stats store, shows an error dialog