This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
Persist activities to a file #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koalalorenzo
suggested changes
Aug 8, 2018
app/index.js
Outdated
| @@ -35,6 +36,7 @@ import ActivitiesWindow from './windows/Activities/window' | |||
| app.mainWindow = null | |||
|
|
|||
| // activities window | |||
| const activityLogPath = pathJoin(app.getPath('userData'), 'activity.log') | |||
koalalorenzo
suggested changes
Aug 8, 2018
|
To test the change request, just create a big file, then add it. Then close the app and re open it with the Activity List.
|
|
Hmm, is it possible to resume them? |
|
I don't think so. :( For now at least. We need a different UI/structure to report failures, allow retry etc etc etc What do you think? |
|
Alright, let's mark them as "interrupted" then :) |
|
We have a bug, while I was just adding a big file to test it, it did not appear on the list of the activities. but when it was completed it was there. https://sentry.io/siderus-opensource/orion/issues/635560601/?environment=development |
koalalorenzo
approved these changes
Aug 8, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Activities will now persist when orion will quit.