This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
Add generic provider for auto updates #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koalalorenzo
suggested changes
Aug 13, 2018
package.json
Outdated
| @@ -81,6 +82,10 @@ | |||
| "testURL": "http://localhost/" | |||
| }, | |||
| "build": { | |||
| "publish": [{ | |||
| "provider": "generic", | |||
| "url": "https://get.siderus.io" | |||
There was a problem hiding this comment.
can we change this to https://get.siderus.io/orion?
…b.com:Siderus/Orion into feature/add-generic-provider-for-auto-updates
|
I am going to add some lines of code to update both GitHub and the pipeline on |
koalalorenzo
approved these changes
Aug 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
So it turns out on linux the auto updates don't work at all. (Not even the popup saying there's a new version available). We should consider checking ourselves doing a get to the
latest.yml.All we need to do to move from github is to upload the artifacts to
get.siderus.io.On windows, the app will do a get to
https://get.siderus.io/latest.yml, check the versions and then downloadhttps://get.siderus.io/Orion-Setup-x.x.x.exe.On mac is the same process, except the file is called
latest-mac.yml.Before we merge we should: