Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify desired the style using .editorconfig #76

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

Chris00
Copy link
Contributor

@Chris00 Chris00 commented Jan 7, 2023

Since this project uses TABs, an .editorconfig file may make the life of users easier.

@Chris00
Copy link
Contributor Author

Chris00 commented Feb 11, 2023

@SiegeLord How about this? This repo does not follow the standard formatting conventions, so it would be nice to let the contributors know — and this is the easiest IMHO as most editors will automatically pick .editorconfig.

@SiegeLord
Copy link
Owner

The style is already described by rustmt.toml, I'd recommend having your editor evoke cargo fmt on save (or manually call cargo fmt).

@Chris00
Copy link
Contributor Author

Chris00 commented Feb 16, 2023

I'd recommend having your editor evoke cargo fmt on save

Yes, I should do that — at least when a rustfmt.toml is present.

I've cleaned up rustfmt configuration (it was generating warnings on nightly) and ran it.

@Chris00
Copy link
Contributor Author

Chris00 commented Feb 16, 2023

Yes, I should do that — at least when a rustfmt.toml is present.

I've done so. 😀

@SiegeLord
Copy link
Owner

Thanks!

@SiegeLord SiegeLord merged commit bfb337c into SiegeLord:master Feb 27, 2023
@Chris00 Chris00 deleted the editorconfig branch February 27, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants