implement add file from buffer #196
Conversation
| await wb.xlsx.load(buffer); | ||
|
|
||
| return new Importer(wb) | ||
|
|
| @@ -26,7 +27,19 @@ describe('reading sigle items (objects)', () => { | |||
| chai.expect(result).eql(expected); | |||
| chai.expect(result.length).equals(1); | |||
| }); | |||
| it('getAllItems should return one correct object from buffer', async () => { | |||
| const factory = new ImporterFactory(); | |||
| const fs = require('fs') | |||
There was a problem hiding this comment.
Import should be moved to the top and use import instead of require to be consistent with other imports.
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 55
Lines 1063 1078 +15
Branches 154 154
=========================================
+ Hits 1063 1078 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@Siemienik Is there anything missing for this PR? |
|
@AlinaKul @kibertoad Thank you for the contribution, that's awesome 😄 . I need time to test it and I'm going to do it at the weekend. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@AlinaKul, great contribution 🥇 Thank you. |
|
@Siemienik happy to help you! |
No description provided.