Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xlsx-renderer: Add installation via CDN #202

Closed
wants to merge 9 commits into from
Closed

Conversation

Siemienik
Copy link
Owner

@Siemienik Siemienik commented Dec 7, 2021

WIP: Introducing webpack to create a bundle available to publish via CDN

TODO:

  • bundler
  • licenses listing
  • choose CDN provider
  • publishing bundle ( I want to avoid publishing via npm or gh EDIT: I choose the way to publish bundle via NPM because it doesn't mess in the repo and additionally it might be useful there)
  • updated readme
  • documentation (website)
  • check if the package will work well after changing the main point (both types and code)
  • do equaliement job for xlsx-import
  • release a version 2.4.5 together with Feature/73 default json mapper response #201
  • check codecov / tests
  • Run all tests with bundled code.

TODO:
 * [ ] licences listing
 * [ ] examples
 * [ ] choose cdn provider
 * [ ] publishing bundle ( I want to avoid publishing via npm or gh)
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #202 (1ef9549) into master (28d5bf3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #202   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        57    +1     
  Lines         1098      1099    +1     
  Branches       154       154           
=========================================
+ Hits          1098      1099    +1     
Flag Coverage Δ
xlsx-import 100.00% <ø> (ø)
xlsx-renderer 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/xlsx-renderer/src/Scope.ts 100.00% <ø> (ø)
packages/xlsx-renderer/src/index.ts 100.00% <100.00%> (ø)
...s/xlsx-renderer/tests/integration/Renderer.test.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d5bf3...1ef9549. Read the comment docs.

@Siemienik Siemienik marked this pull request as draft December 7, 2021 19:47
@Siemienik Siemienik changed the title WIP: Introducing webpack to create a bundle available to publish via CDN Xlsx-renderer: Add installation via CDN Dec 7, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Siemienik Siemienik self-assigned this Dec 12, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Siemienik Siemienik closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Release
Development

Successfully merging this pull request may close these issues.

1 participant