Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Strategy Selection and Improve Tool Page Description Display #587

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

siganberg
Copy link

Summary:

This pull request includes the following improvements to the tool settings functionality:

  1. Moved Passthrough to Strategy Dropdown

    • Passthrough is now implemented as a strategy option within the dropdown instead of being a standalone checkbox.
    • This ensures that strategies remain mutually exclusive, improving clarity and consistency in user selection.
  2. Fixed Strategy Description Display

    • The description for a selected strategy now appears immediately on the Tool Page settings, without requiring a user to change the dropdown value.
    • Enhances user experience by providing immediate feedback and context for the selected strategy.

Changes:

  • Updated UI logic to include "Passthrough" as a dropdown option.
  • Removed the checkbox implementation for Passthrough.
  • Modified description rendering logic to display information immediately upon page load.

Testing:

  • Verified that all strategies, including Passthrough, appear in the dropdown and are mutually exclusive.
  • Ensured the strategy descriptions render correctly on the Tool Page settings without interaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant