[MIRROR] Refactors mil_rank sort_order #2911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Оригинальный PR: Baystation12#34822
🆑 JuneauQT
tweak: Refactors ranking orders of Fleet and Expeditionary Corps ranks to the newer standard
bugfix: The 'Admiral' and 'Commandant of the Expeditionary Corps' ranks of the Expedtionary Corps now function correctly.
tweak; Refactors ranking orders of SCGA and ICCGN to match the integration of Fleet and Corps into the standard.
/:cl:
Updates the Fleet and Corps ranks to the standard used by the ICCGN and SCGA. Also alters the ICCGN and SCGA ranks to the slightly modified standard now used by the fleet and corps.
The new sort_order for ranks is as follows:
I've confirmed that, at the very least, O-Mess and the Uniform Vendors still function appropriately. If anything ever makes the paygrade variable publicly visible again sub-ranks will render with decimal values, but this is probably fine.