-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposing Bluebird in the API is unrealistic #95
Comments
Hi @lookfirst, Thanks for opening this issue. As a matter of fact, the reason 8.x is still in alpha is that I do intend on switching to native Promises before it is released (I simply haven't had the chance to sit down and do the refactor yet). As you touched on, it is a long running pain point with the library and one which was borne of the early days of Rest assured, I have every intention of improving this aspect of the experience and will keep you apprised of my progress on that front. I'm glad that, with the exception of this, you're enjoying the library and please do open issues if there are any other aspects which rub you the wrong way. Regards, |
I've just released |
… the build to erroneously pass
I just tried and yarn is still only grabbing a2 for some reason. |
Sorry about that, I published it under the wrong tag ( |
Thanks man. It cleaned up a bunch of code for me. =) |
There are other closed issues around this, but it still seems to be an open sore point even in 8.x, so let me provide a bit more context.
The fact that you return Bluebird in the interfaces is a real bummer. I don't care what Promise implementation you use under the covers, but I don't want to pollute the rest of my code with BB references.
Your connection example code has issues because connecting to mongo is async... you have to wait for the promise to fulfill before trying to do things with the database...
For example, I have to do this convoluted thing...
Or even this...
I'm sure I can do a bunch with my own generic helpers to clean this up, but I'd rather your code just help me out. =) Other than this, I'm really happy with your project. So much more sane than the alternatives. Please consider this positive feedback!
The text was updated successfully, but these errors were encountered: