API-7698: Fix possible issue with connection becoming stalled after interrupt during call.execute #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Our customer experiences SocketTimeoutException with sift-java.
Overall it looks like this is still an open issue with okhttp.
Technical details
Seems, When using Call.execute() which is synchronous, the actual initial request processing including writing to the HTTP/2 socket is done on the calling thread, so an interrupt leaves the HTTP/2 connection in an inconsistent state.
Workarounds:
Another workaround with implementation proposed -
always use enqueue, even to simulate an execute so the thread writing the underlying socket is never a user thread that can be interrupted.
Seems this is the most optimal fix, and will be implemented in this PR.
With the current fix
siftClient. enqueueRequests()
will useenqueue
instead ofexecute