Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pagination component #20

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: add pagination component #20

wants to merge 6 commits into from

Conversation

ahmadshaheer
Copy link
Contributor

@ahmadshaheer ahmadshaheer commented Oct 13, 2024 •
edited
Loading

image

@ahmadshaheer ahmadshaheer force-pushed the feat/add-pagination-component branch from a83df8c to 871b151 Compare October 28, 2024 07:29
YounixM
YounixM reviewed Oct 28, 2024
View reviewed changes
apps/docs/stories/pagination.stories.tsx Outdated
} from "@signozhq/pagination";

const PaginationComponent = () => (
<Pagination>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmadshaheer : Can we use the component similar to how the consuming application will be using?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like

<Pagination align="end" defaultCurrent={1} total={50} />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check https://ant.design/components/pagination for examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@YounixM
Copy link
Member

YounixM commented Oct 28, 2024

@ahmadshaheer : the story should list all the props the component accepts.

@ahmadshaheer ahmadshaheer requested a review from YounixM October 30, 2024 08:58
@ahmadshaheer ahmadshaheer force-pushed the feat/add-pagination-component branch from b7d5fc3 to ea2e30b Compare November 11, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM Awaiting requested review from YounixM

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmadshaheer @YounixM