fix: address review comments

SigNoz · Jun 10, 2024 · 1dabf8a · 1dabf8a
1 parent f2dc062
commit 1dabf8a
Showing 1 changed file with 13 additions and 13 deletions.
diff --git a/frontend/src/container/NewDashboard/DashboardSettings/General/index.tsx b/frontend/src/container/NewDashboard/DashboardSettings/General/index.tsx
@@ -71,18 +71,18 @@ function GeneralDashboardSettings(): JSX.Element {
 
 	useEffect(() => {
 		let numberOfUnsavedChanges = 0;
-		if (!isEqual(updatedTitle, title)) {
-			numberOfUnsavedChanges += 1;
-		}
-		if (!isEqual(updatedDescription, description)) {
-			numberOfUnsavedChanges += 1;
-		}
-		if (!isEqual(updatedTags, tags)) {
-			numberOfUnsavedChanges += 1;
-		}
-		if (!isEqual(updatedImage, image)) {
-			numberOfUnsavedChanges += 1;
-		}
+		const initialValues = [title, description, tags, image];
+		const updatedValues = [
+			updatedTitle,
+			updatedDescription,
+			updatedTags,
+			updatedImage,
+		];
+		initialValues.forEach((val, index) => {
+			if (!isEqual(val, updatedValues[index])) {
+				numberOfUnsavedChanges += 1;
+			}
+		});
 		setNumberOfUnsavedChanges(numberOfUnsavedChanges);
 	}, [
 		description,
@@ -167,7 +167,7 @@ function GeneralDashboardSettings(): JSX.Element {
 					<div className="unsaved">
 						<div className="unsaved-dot" />
 						<Typography.Text className="unsaved-changes">
-							{numberOfUnsavedChanges} Unsaved change
+							{numberOfUnsavedChanges} unsaved change
 							{numberOfUnsavedChanges > 1 && 's'}
 						</Typography.Text>
 					</div>