fix: added billing page condition to not show when its not either clo…

…ud or enterprise (#4827)
SigNoz · Apr 9, 2024 · e9bb05c · e9bb05c
1 parent 31c0b94
commit e9bb05c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/frontend/src/AppRoutes/index.tsx b/frontend/src/AppRoutes/index.tsx
@@ -147,7 +147,11 @@ function App(): JSX.Element {
 			}
 		}
 
-		if (isOnBasicPlan || (isLoggedInState && role && role !== 'ADMIN')) {
+		if (
+			isOnBasicPlan ||
+			(isLoggedInState && role && role !== 'ADMIN') ||
+			!(isCloudUserVal || isEECloudUser())
+		) {
 			const newRoutes = routes.filter((route) => route?.path !== ROUTES.BILLING);
 			setRoutes(newRoutes);
 		}

diff --git a/frontend/src/container/SideNav/SideNav.tsx b/frontend/src/container/SideNav/SideNav.tsx
@@ -96,6 +96,8 @@ function SideNav({
 
 	const { registerShortcut, deregisterShortcut } = useKeyboardHotkeys();
 
+	const isCloudUserVal = isCloudUser();
+
 	useEffect(() => {
 		if (inviteMembers) {
 			const updatedUserManagementMenuItems = [
@@ -135,7 +137,11 @@ function SideNav({
 						license.isCurrent && license.planKey === LICENSE_PLAN_KEY.BASIC_PLAN,
 				) || licenseData?.payload?.licenses === null;
 
-			if (role !== USER_ROLES.ADMIN || isOnBasicPlan) {
+			if (
+				role !== USER_ROLES.ADMIN ||
+				isOnBasicPlan ||
+				!(isCloudUserVal || isEECloudUser())
+			) {
 				items = items.filter((item) => item.key !== ROUTES.BILLING);
 			}
 
@@ -214,8 +220,6 @@ function SideNav({
 		pathname,
 	]);
 
-	const isCloudUserVal = isCloudUser();
-
 	useEffect(() => {
 		if (isCloudUser() || isEECloudUser()) {
 			const updatedUserManagementMenuItems = [helpSupportMenuItem];