Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: live tail time out is updated #1899

Merged
merged 11 commits into from
Dec 27, 2022
Merged

fix: live tail time out is updated #1899

merged 11 commits into from
Dec 27, 2022

Conversation

palashgdev
Copy link
Contributor

close #1894

@github-actions github-actions bot added the bug Something isn't working label Dec 22, 2022
@nityanandagohain
Copy link
Member

Were you able to test it using the API?

@palashgdev
Copy link
Contributor Author

Were you able to test it using the API?

how to test via API ?

@palashgdev
Copy link
Contributor Author

though i have confirmed this one with UI

@pranay01 pranay01 modified the milestones: v0.12.1, v0.13.0 Dec 26, 2022
@ankitnayan
Copy link
Collaborator

@palashgdev @nityanandagohain this does not seem to fix the issue. Please have a look again.

@palashgdev
Copy link
Contributor Author

@nityanandagohain config is right but what could be the possible reason https://github.com/Yaffle/EventSource/blob/master/src/eventsource.js#LL742C50-L742C66 ?

@pranay01 pranay01 modified the milestones: v0.12.1, v0.13.0 Dec 26, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ankitnayan ankitnayan merged commit 13a6d7f into develop Dec 27, 2022
@ankitnayan ankitnayan deleted the 1894 branch December 27, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitnayan ankitnayan ankitnayan left review comments

@nityanandagohain nityanandagohain nityanandagohain approved these changes

Assignees
No one assigned
Labels
bug Something isn't working codeball:needs-careful-review Codeball
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

Frontend closes live tail connection when there is no activity for 45000 ms
4 participants
@palashgdev @nityanandagohain @ankitnayan @pranay01