Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: per page is added in the dependancy #1926

Merged
merged 1 commit into from
Dec 27, 2022
Merged

fix: per page is added in the dependancy #1926

merged 1 commit into from
Dec 27, 2022

Conversation

palashgdev
Copy link
Contributor

Close #1916

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added bug Something isn't working codeball:approved Codeball labels Dec 27, 2022
github-actions[bot]
github-actions bot approved these changes Dec 27, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.98 | [dashboard]

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pranay01
pranay01 approved these changes Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@pranay01 pranay01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a functionality perspective. Though there is a bit of delay in the calls - I guess that is because of the time period we provided in the debounceHandler

@pranay01 pranay01 added this to the v0.13.0 milestone Dec 27, 2022
@ankitnayan ankitnayan merged commit 40ec451 into develop Dec 27, 2022
@ankitnayan ankitnayan deleted the 1916 branch December 27, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranay01 pranay01 pranay01 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@ankitnayan ankitnayan Awaiting requested review from ankitnayan

Assignees
No one assigned
Labels
bug Something isn't working codeball:approved Codeball
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

Changing the page size in pagination in the logs page should trigger a new api call with new limit value
3 participants
@palashgdev @pranay01 @ankitnayan