Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FE): AppRoutes is refactored #260

Merged
merged 15 commits into from
Aug 23, 2021
Merged

fix(FE): AppRoutes is refactored #260

merged 15 commits into from
Aug 23, 2021

Conversation

palashgdev
Copy link
Contributor

Following Pointers are resolved in this PR

  1. Spinner Component is updated
  2. Page Components are fetched in Lazy mode with name Screenshot 2021-08-18 at 4 07 25 PM
  3. AppRoutes are refactored

@palashgdev palashgdev requested a review from ankitnayan August 18, 2021 10:38
@palashgdev palashgdev self-assigned this Aug 18, 2021
jyash97
jyash97 reviewed Aug 19, 2021
View reviewed changes
frontend/src/index.tsx Outdated Show resolved Hide resolved
@palashgdev palashgdev requested a review from jyash97 August 19, 2021 09:10
@palashgdev palashgdev requested a review from jyash97 August 20, 2021 08:30
@ankitnayan ankitnayan merged commit 9008d19 into SigNoz:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitnayan ankitnayan ankitnayan approved these changes

@jyash97 jyash97 Awaiting requested review from jyash97

Assignees

@palashgdev palashgdev

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palashgdev @ankitnayan @jyash97