Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ESLint and Prettier in CI pipeline #329

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

szatyinadam
Copy link
Contributor

This pull request add ESLint and Prettier to the CI pipeline, according to #280 .
There are some issues in the current code that makes ESLint and Prettier fail, so I've put the continue-on-error: true flag, but that should be removed if the issues will be fixed.

@pranay01
Copy link
Collaborator

pranay01 commented Oct 2, 2021

thanks @szatyinadam
@ankitnayan can you check this PR

@pranay01 pranay01 requested a review from ankitnayan October 2, 2021 05:09
@ankitnayan ankitnayan requested a review from palashgdev October 3, 2021 07:43
@palashgdev palashgdev self-requested a review October 4, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants