feat(query-builder): add limit, order by and having clause to formula #3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would appreciate it if you could provide us with more info about this issue/pr! |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Seems to be working. I will test this against some more production like data. |
|
I pushed the query-service changes also to this branch. Let's fix the point shared in Slack and get this merged. |
srikanthccv
changed the title
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
srikanthccv
previously approved these changes
Sep 26, 2023
|
@palashgdev please merge if there will be no reviews required from frontend team side. |
Rajat-Dabade
suggested changes
Sep 27, 2023
frontend/src/container/QueryBuilder/filters/Formula/Having/HavingFilter.tsx
Show resolved
Hide resolved
frontend/src/container/QueryBuilder/filters/Formula/Having/HavingFilter.tsx
Show resolved
Hide resolved
frontend/src/container/QueryBuilder/filters/Formula/Having/HavingFilter.tsx
Show resolved
Hide resolved
frontend/src/container/QueryBuilder/filters/Formula/Having/HavingFilter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/container/QueryBuilder/filters/Formula/Having/HavingFilter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/container/QueryBuilder/filters/Formula/OrderBy/useOrderByFormulaFilter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/container/QueryBuilder/filters/Formula/OrderBy/useOrderByFormulaFilter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/container/QueryBuilder/filters/Formula/OrderBy/useOrderByFormulaFilter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/container/QueryBuilder/filters/Formula/OrderBy/useOrderByFormulaFilter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/container/QueryBuilder/filters/Formula/OrderBy/useOrderByFormulaFilter.tsx
Outdated
Show resolved
Hide resolved
|
@Rajat-Dabade please take a look again. |
YounixM
approved these changes
Sep 27, 2023
srikanthccv
approved these changes
Sep 27, 2023
manishm
pushed a commit
to manishm/SIGFOR
that referenced
this pull request
Sep 27, 2023
…SigNoz#3623) * feat: query builder formula is updated * feat: formula is updated for having and limit * feat: orderBy is updated * feat: formula is added * chore: add query-service support for formula limit and order by * feat: enable more filters is displayed when all data source is metrics * chore: feedback is updated * chore: feedback is updated --------- Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com> Co-authored-by: Rajat Dabade <rajat@signoz.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.