Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: try Signoz button is visible on success #3906

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: try Signoz button is visible on success #3906

merged 1 commit into from
Nov 10, 2023

Conversation

palashgdev
Copy link
Contributor

Close #3905

@palashgdev palashgdev self-assigned this Nov 6, 2023
@palashgdev palashgdev requested a review from YounixM as a code owner November 6, 2023 12:04
@github-actions github-actions bot added the bug Something isn't working label Nov 6, 2023
@palashgdev palashgdev changed the title fix: try Signoz is visible on success fix: try Signoz button is visible on success Nov 6, 2023
Rajat-Dabade
Rajat-Dabade approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@palashgdev palashgdev merged commit 30b0d42 into develop Nov 10, 2023
8 checks passed
@palashgdev palashgdev deleted the fix/3905 branch November 10, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajat-Dabade Rajat-Dabade Rajat-Dabade approved these changes

@YounixM YounixM YounixM approved these changes

Assignees

@palashgdev palashgdev

Labels
bug Something isn't working frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(FE): Try Signoz is visible during loading and invalid token calls
3 participants
@palashgdev @YounixM @Rajat-Dabade