feat: happy flow for services from list view to all the three details tab rendering the correct tables #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vikrantgupta25
commented
Nov 9, 2023
•
vikrantgupta25
commented
- Added end to end flow for services tabs validating the presence of the necessary tables in the concerned tables
|
We would appreciate it if you could provide us with more info about this issue/pr! |
vikrantgupta25
force-pushed
the
services-flow
branch
from
1ae05df to
845cdc4
Compare
vikrantgupta25
changed the title
palashgdev
reviewed
Nov 10, 2023
YounixM
approved these changes
Nov 14, 2023
palashgdev
reviewed
Nov 14, 2023
palashgdev
reviewed
Nov 14, 2023
palashgdev
reviewed
Nov 14, 2023
|
Will address the comments in the follow up PR #3960 |
please pick the issues from resolve conservation though this LGTM |
vikrantgupta25
added a commit
to vikrantgupta25/signoz
that referenced
this pull request
Nov 16, 2023
… tab rendering the correct tables (SigNoz#3942) * feat: complete services flow * feat: complete all the three tab flows * feat: address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.