Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ESLint Rules #409 #426

Merged
merged 5 commits into from
Dec 2, 2021
Merged

Improve ESLint Rules #409 #426

merged 5 commits into from
Dec 2, 2021

Conversation

rishitxyz
Copy link
Contributor

@rishitxyz rishitxyz commented Nov 30, 2021

fix #409

  • added eslint rule to not to use array index as a key for components.
  • fixed the components in frontend that created error because of the new eslint rule.

@palashgdev
Copy link
Contributor

also are there only 2 place which require attention ?

@rishitxyz
Copy link
Contributor Author

also are there only 2 place which require attention ?

Yup, I manually checked files and there were only two files which needed the attention about this new rule. There were a lot of files with map function being used to render components but were not using indices as key.

@palashgdev
Copy link
Contributor

also are there only 2 place which require attention ?

Yup, I manually checked files and there were only two files which needed the attention about this new rule. There were a lot of files with map function being used to render components but were not using indices as key.

use lint command don't check manually

@rishitxyz
Copy link
Contributor Author

use lint command don't check manually

I even did that too and then manually checked those files.

@rishitxyz
Copy link
Contributor Author

One of the errors that I am currently having is about line-breaks. I am on a Windows machine and I face this error. We do have an eslint rule about this but that only applies to operating systems based on unix (linux, macOS).

frontend/src/AppRoutes/index.tsx Outdated Show resolved Hide resolved
@palashgdev
Copy link
Contributor

One of the errors that I am currently having is about line-breaks. I am on a Windows machine and I face this error. We do have an eslint rule about this but that only applies to operating systems based on unix (linux, macOS).

Yeah agreed we can make a separate issue for this one i guess

do you want to take this one ?

@rishitxyz
Copy link
Contributor Author

rishitxyz commented Dec 2, 2021

Yeah agreed we can make a separate issue for this one i guess

do you want to take this one ?

I ll be happy to work on this. I will create an issue first and then make a pull request for it once we decide a way to solve the issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@palashgdev palashgdev self-requested a review December 2, 2021 11:27
@palashgdev palashgdev self-assigned this Dec 2, 2021
@palashgdev palashgdev added frontend bug Something isn't working labels Dec 2, 2021
@palashgdev palashgdev assigned rishitxyz and unassigned palashgdev Dec 2, 2021
@ankitnayan ankitnayan merged commit 5e4cff7 into SigNoz:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Eslint Rules
3 participants