-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ESLint Rules #409 #426
Conversation
frontend/src/container/NewWidget/LeftContainer/QuerySection/index.tsx
Outdated
Show resolved
Hide resolved
also are there only 2 place which require attention ? |
Yup, I manually checked files and there were only two files which needed the attention about this new rule. There were a lot of files with map function being used to render components but were not using indices as key. |
use lint command don't check manually |
I even did that too and then manually checked those files. |
One of the errors that I am currently having is about line-breaks. I am on a Windows machine and I face this error. We do have an |
Yeah agreed we can make a separate issue for this one i guess do you want to take this one ? |
I ll be happy to work on this. I will create an issue first and then make a pull request for it once we decide a way to solve the issue. |
Kudos, SonarCloud Quality Gate passed!
|
fix #409