Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [SIG-567]: prevented stage-&-run API on legend change #4720

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Mar 19, 2024

Summary

Prevented stage-&-run API on legend change:

  • we were updating legends based on api-response earlier hence this required us to run stage-&-run query API every time we want to update the legend format.
  • Added other option to update legend format from current query coming from useQueryBuilder as this was getting updated on every onChange event of the legend format input.
  • Have safety check so that when the current query is not provided then the updation will happen as previously.

Related Issues / PR's

#3568

Screen.Recording.2024-03-19.at.6.27.03.AM.mov

Screenshots

NA

Affected Areas and Manually Tested Areas

@SagarRajput-7 SagarRajput-7 requested a review from YounixM as a code owner March 19, 2024 01:05
@CLAassistant
Copy link

CLAassistant commented Mar 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ SagarRajput-7
❌ Sagar Rajput


Sagar Rajput seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Mar 19, 2024
@SagarRajput-7 SagarRajput-7 self-assigned this Mar 19, 2024
@SagarRajput-7 SagarRajput-7 changed the title fix: prevented stage-&-run API on legend change fix: [SIG-567]: prevented stage-&-run API on legend change Mar 20, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM
Copy link
Member

YounixM commented Mar 20, 2024

Can you please add the details around the change for this?

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM merged commit 0df8645 into develop Mar 21, 2024
10 of 11 checks passed
@YounixM YounixM deleted the fix-3568 branch March 21, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Applying legends should not need to run Stage and Run Query again
5 participants