-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) send 403 on wrong password entry during change password operation #4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
makeavish
reviewed
Mar 21, 2024
This is how are we handling
There were multiple cases to consider but we just focused on the Is it safe to presume we need to handle multiple cases in login as well? |
5848c1c
to
852e9f7
Compare
…tion for forbidden errors
852e9f7
to
67b3c70
Compare
srikanthccv
approved these changes
Mar 25, 2024
makeavish
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Incorrect status code is being sent when a user enters wrong password while trying to update their password!
Related Issues / PR's
#1101
Screenshots
NA
Affected Areas and Manually Tested Areas