Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) send 403 on wrong password entry during change password operation #4733

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

grandwizard28
Copy link
Collaborator

Summary

Incorrect status code is being sent when a user enters wrong password while trying to update their password!

Related Issues / PR's

#1101

Screenshots

NA

Affected Areas and Manually Tested Areas

  • Change Password Screen

Copy link

welcome bot commented Mar 21, 2024

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the bug Something isn't working label Mar 21, 2024
@grandwizard28
Copy link
Collaborator Author

This is how are we handling /login as well

resp, err := auth.Login(context.Background(), req)
	if aH.HandleError(w, err, http.StatusUnauthorized) {
		return
	}

There were multiple cases to consider but we just focused on the StatusUnauthorized case!

Is it safe to presume we need to handle multiple cases in login as well?

@srikanthccv srikanthccv merged commit 9948148 into develop Mar 26, 2024
11 checks passed
Copy link

welcome bot commented Mar 26, 2024

Congrats on merging your first pull request!
minion-party
We here at SigNoz are proud of you! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants