Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alert threshold form is resetting to default query option on stage & run #4876

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Apr 17, 2024

Summary

In Alert form the threshold form value - query name in select is resetting to default (index - 0) on reload

Related Issues / PR's

Screenshots

Before:

Screen.Recording.2024-04-17.at.4.17.34.PM.mov

After:

Screen.Recording.2024-04-17.at.4.18.02.PM.mov

Affected Areas and Manually Tested Areas

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Apr 17, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 marked this pull request as ready for review April 23, 2024 06:19
@SagarRajput-7 SagarRajput-7 requested a review from YounixM as a code owner April 23, 2024 06:19
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Member

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SagarRajput-7 SagarRajput-7 merged commit 1306e99 into develop Apr 24, 2024
11 checks passed
@prashant-shahi prashant-shahi deleted the alert-threshold-form-issue branch June 20, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants