Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not save dashboard panel on creating a new panel if discard is pressed #4884

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix: do not save dashboard panel on creating a new panel if discard is pressed #4884

merged 2 commits into from
Apr 23, 2024

Conversation

vikrantgupta25
Copy link
Member

@vikrantgupta25 vikrantgupta25 commented Apr 18, 2024 •
edited
Loading

Summary

  • do not make PUT call to update dashboard as soon as the addPanel button is clicked
  • the save call for the new panel should only be done on save of the panel
  • if the user clicks discard nothing should happen

Related Issues / PR's

Fixes - https://github.com/SigNoz/engineering-pod/issues/1249

Screenshots

NA

Affected Areas and Manually Tested Areas

  • dashboard list
  • dashboard create panel
  • edit panel
  • delete panel
  • new dashboard / existing dashboard

@github-actions github-actions bot added the bug Something isn't working label Apr 18, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review April 18, 2024 18:23
@vikrantgupta25 vikrantgupta25 requested a review from YounixM as a code owner April 18, 2024 18:23
@vikrantgupta25 vikrantgupta25 changed the title fix: do not save dashboard panel on creating a new panel if discard i… fix: do not save dashboard panel on creating a new panel if discard is pressed Apr 18, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 merged commit 5e3dba2 into develop Apr 23, 2024
11 checks passed
@vikrantgupta25 vikrantgupta25 deleted the panel-discard-issue branch April 23, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@SagarRajput-7 SagarRajput-7 SagarRajput-7 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikrantgupta25 @YounixM @SagarRajput-7