Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle-large-traces #4903

Merged
merged 13 commits into from
May 27, 2024
Merged

fix: handle-large-traces #4903

merged 13 commits into from
May 27, 2024

Conversation

makeavish
Copy link
Member

@makeavish makeavish commented Apr 23, 2024 •
edited
Loading

Summary

  1. Fix span not found error when opening large traces from Traces tab
  2. Fix query service crashing with OOM errors due to loading huge traces in memory by introducing max span in trace limit with variable: MAX_SPANS_IN_TRACE, set to 250000 by default
  3. Reduce SPAN_RENDER_LIMIT to 2500 by default. Allow changing SPAN_RENDER_LIMIT with spanRenderLimit param in trace detail URL - Will need frontend change, should not be required for now as SPAN_RENDER_LIMIT is just an env variable. Will update it later

Screenshots

Screenshot 2024-05-24 at 17 56 40 Screenshot 2024-05-24 at 17 56 14 Screenshot 2024-05-24 at 21 29 24

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Apr 23, 2024
@makeavish makeavish requested a review from srikanthccv April 23, 2024 18:23
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

3 similar comments
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@makeavish makeavish marked this pull request as ready for review May 16, 2024 17:00
@makeavish
feat: add isSubTree key to identify subTrees
668d127 
Show user a loom video explaining how to navigate large spans
@makeavish makeavish requested a review from YounixM as a code owner May 16, 2024 17:51
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

srikanthccv
srikanthccv previously approved these changes May 21, 2024
View reviewed changes
@makeavish makeavish requested a review from prashant-shahi May 24, 2024 11:01
@makeavish makeavish requested review from srikanthccv and YounixM May 24, 2024 12:39
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@makeavish makeavish merged commit 96162d7 into develop May 27, 2024
11 of 12 checks passed
@makeavish makeavish deleted the fix/handle-large-traces branch May 27, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@prashant-shahi prashant-shahi Awaiting requested review from prashant-shahi

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makeavish @YounixM @srikanthccv