fix: ch queries sending builder as query type in query range api for exceptions alerts #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikrantgupta25
changed the title
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
SagarRajput-7
previously approved these changes
Apr 30, 2024
SagarRajput-7
previously approved these changes
Apr 30, 2024
…exceptions alerts
…exceptions alerts
vikrantgupta25
force-pushed
the
alerts-exceptions-fix
branch
from
7876a0d to
bdf5a73
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
YounixM
approved these changes
May 1, 2024
SagarRajput-7
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
datasourcefrom query hence the exceptions alerts were not working as expected as it always routed to trace based alerts.alertTypeas query params to maintain the sanityalertTypeis not present we will extract the same from staged query like we are doing currently to support backwards compatibilityRelated Issues / PR's
Screenshots
Logs -> Alerts
Dashboard (Traces / Logs / Metrics ) -> Alerts
Screen.Recording.2024-05-01.at.2.34.57.PM.mov
Alerts UI navigation
Screen.Recording.2024-04-30.at.5.28.35.PM.mov
Affected Areas and Manually Tested Areas