Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple widgets getting created and hence blocking the delete #5015

Merged
merged 4 commits into from
May 17, 2024
Merged

fix: multiple widgets getting created and hence blocking the delete #5015

merged 4 commits into from
May 17, 2024

Conversation

vikrantgupta25
Copy link
Member

@vikrantgupta25 vikrantgupta25 commented May 16, 2024 •
edited by srikanthccv
Loading

Summary

Fixes https://github.com/SigNoz/engineering-pod/issues/1288

  • the pre and after widgets didn't handle the -1 index case hence they were adding multiple widgets with same ids
  • now since a few dashboards might have been corrupted so to allow users to delete the existing panels added support for users to multiple deletes when same widget id is removed multiple times

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas

  • UI changes with latest backend changes
  • backend changes with postman

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label May 16, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review May 16, 2024 12:28
@vikrantgupta25 vikrantgupta25 requested a review from YounixM as a code owner May 16, 2024 12:28
srikanthccv
srikanthccv previously approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv
Copy link
Member

Merging this. Please continue the discussion if it's not answered.

@srikanthccv srikanthccv merged commit d313f44 into develop May 17, 2024
12 checks passed
@srikanthccv srikanthccv deleted the fix-multiple-widgets-issue branch May 17, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitnayan ankitnayan ankitnayan left review comments

@srikanthccv srikanthccv srikanthccv approved these changes

@YounixM YounixM YounixM approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vikrantgupta25 @srikanthccv @YounixM @ankitnayan