Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cursor resetting in dropdown causing wrong query selection #5063

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: cursor resetting in dropdown causing wrong query selection #5063

merged 1 commit into from
May 23, 2024

Conversation

vikrantgupta25
Copy link
Member

Summary

  • due to the aggregate keys fetch call the options dropdown was re-rendering hence the cursor reset.
  • added the loading state handling

Related Issues / PR's

fixes :- #5059

Screenshots

NA

Affected Areas and Manually Tested Areas

@vikrantgupta25 vikrantgupta25 requested a review from YounixM as a code owner May 22, 2024 18:55
@github-actions github-actions bot added the bug Something isn't working label May 22, 2024
@YounixM YounixM merged commit da74619 into develop May 23, 2024
11 of 12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the cursor-reset branch May 23, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@SagarRajput-7 SagarRajput-7 SagarRajput-7 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikrantgupta25 @YounixM @SagarRajput-7