-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add AWS RDS and ElastiCache integration #5071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments.
I am yet to try following the instructions for the integrations. Will try and get that done today/tomorrow
...ervice/app/integrations/builtin_integrations/aws_rds_mysql/assets/dashboards/db_metrics.json
Show resolved
Hide resolved
...ntegrations/builtin_integrations/aws_rds_postgres/assets/dashboards/db_metrics_overview.json
Show resolved
Hide resolved
...rvice/app/integrations/builtin_integrations/aws_rds_postgres/assets/dashboards/overview.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more minor comments
LGTM 👍
Summary
Related to #4673