Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added trace-filter in new trace-explorer #5081

Merged
merged 23 commits into from
Jun 4, 2024
Merged

feat: added trace-filter in new trace-explorer #5081

merged 23 commits into from
Jun 4, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented May 27, 2024 •
edited
Loading

Summary

Related Issues / PR's

Screenshots

image

Functionality video -

Screen.Recording.2024-05-30.at.11.05.16.AM.mov

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the enhancement New feature or request label May 27, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 marked this pull request as ready for review May 30, 2024 05:24
@SagarRajput-7 SagarRajput-7 requested a review from YounixM as a code owner May 30, 2024 05:24
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@ankitnayan ankitnayan requested a review from makeavish June 1, 2024 05:31
YounixM
YounixM approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@YounixM YounixM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the open comments, Rest LGTM

vikrantgupta25
vikrantgupta25 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , can take care of comments in next PR as well. Looks good 🚀

@SagarRajput-7
feat: added trace-filter in new trace-explorer
8a9b4a8
@SagarRajput-7
feat: added trace-filter in new trace-explorer
2929871
@SagarRajput-7
feat: style improvement
6c41e69
@SagarRajput-7
feat: query builder sync and filter section refactor
0b7d3c7
@SagarRajput-7
feat: added duration and code refactor
ba91bdf
@SagarRajput-7
feat: added default open case
1be1b96
@SagarRajput-7
feat: removed API calls and used keys from const
dede20f
@SagarRajput-7
feat: added sync and prepare data logic for querybuilder
e693e6b
@SagarRajput-7
feat: added styles for lightmode
d5a35f3
@SagarRajput-7
feat: code refactor and sync issue fixed
e17f7ae
@SagarRajput-7
feat: code refactor and sync issue fixed
3f33199
@SagarRajput-7
feat: code refactor and feedback issue fixed
17615cf
@SagarRajput-7
feat: checkbox label and other feedback fix
453376c
@SagarRajput-7
feat: filter open and close btn style and handling
9fc385c
@SagarRajput-7
feat: added filter reset and clear all
479dd0e
@SagarRajput-7
feat: fixed query modification issue when filtering
5619559
@SagarRajput-7
feat: code refactor
628283e
@SagarRajput-7
feat: search text via BE API
2ceb517
@SagarRajput-7
feat: added CTA btn for old explorer page
f6dd430
@SagarRajput-7
feat: make trace-explorer default page
180de08
@SagarRajput-7
feat: removed new ribbon on CTA for old trace explorer
ba25fb9
@SagarRajput-7
feat: fixed qb and filter panel sync via url state
d821d2c
@SagarRajput-7
feat: fixed duration section issues
b6bcc53
@SagarRajput-7 SagarRajput-7 merged commit 9733612 into develop Jun 4, 2024
11 of 12 checks passed
@SagarRajput-7 SagarRajput-7 deleted the tracing-filters branch June 4, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@vikrantgupta25 vikrantgupta25 vikrantgupta25 approved these changes

@makeavish makeavish Awaiting requested review from makeavish

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SagarRajput-7 @YounixM @vikrantgupta25