feat: add spanKind and status in span response #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makeavish
previously approved these changes
May 31, 2024
nityanandagohain
changed the title
makeavish
approved these changes
May 31, 2024
|
One question: do these show up in attribute suggestions? If not, I believe they should be included as well. It doesn't have to be in this PR if you prefer that way. |
|
@srikanthccv yes they show up , as they are driven by tag attributes
|
|
Should we wait for the data to be backfilled for a week? and only show the string version kind i.e. |
|
Yeah we can wait for backfill and then release this, not sure if we should remove Meanwhile we will also need a frontend PR to show this values in the trace detail page. |
srikanthccv
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4925
add spanKind and statusCodeString and statusMessage