Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard variables should properly load for imported dashboards #5123

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

vikrantgupta25
Copy link
Member

@vikrantgupta25 vikrantgupta25 commented May 31, 2024

Summary

  • imported dashboards variables not working and showing empty data
  • now since we moved to sequential approach we check for variablesToBeUpdated queue and the variable should be present in the queue to get updated.
  • now even if we add the variables on the first load of dashboard it won't work as it will update all the existing values nested structure as well.
  • so we only update if either present in queue or the selectedValue is not something that came in the new options.

Related Issues / PR's

fixes #5121

Screenshots

Screen.Recording.2024-05-31.at.3.51.18.PM.mov

Affected Areas and Manually Tested Areas

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label May 31, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review May 31, 2024 10:39
@vikrantgupta25 vikrantgupta25 requested a review from YounixM as a code owner May 31, 2024 10:39
@srikanthccv
Copy link
Member

This one is tricky. I will take a look.

@srikanthccv srikanthccv self-assigned this May 31, 2024
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One a separate note, It would be great to have tests for small changes so that the test suite grows over the time.

@vikrantgupta25 vikrantgupta25 merged commit ac2dc44 into develop Jun 4, 2024
11 of 12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the dashboard-variables-import-payload branch June 4, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect variable values when dashboard is imported for the first time
3 participants