Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clickhouse and promQL queries table column headers not handled #5164

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

vikrantgupta25
Copy link
Member

@vikrantgupta25 vikrantgupta25 commented Jun 6, 2024

Summary

  • the handling for adding the correct table columns based on legend or the operators was not present
  • fixes the column units respecting clickhouse and promQL queries as well

Related Issues / PR's

fixes #5156

Screenshots

Screen.Recording.2024-06-06.at.7.53.41.PM.mov

Affected Areas and Manually Tested Areas

@vikrantgupta25 vikrantgupta25 requested a review from YounixM as a code owner June 6, 2024 14:17
@github-actions github-actions bot added the bug Something isn't working label Jun 6, 2024
@srikanthccv
Copy link
Member

Let's hold this for some time. We are going to change the way ClickHouse queries are handled so we don't have to worry about the column name details.

@vikrantgupta25
Copy link
Member Author

Let's hold this for some time. We are going to change the way ClickHouse queries are handled so we don't have to worry about the column name details.

can you point me to what change are we expecting ? we can get this out if that change might take some time ? because currently there is no handling for clickhouse and promQL so either the default count appears or whatever values present in the QB appears.

@YounixM YounixM self-requested a review June 7, 2024 06:40
@srikanthccv
Copy link
Member

can you point me to what change are we expecting ?

There won't be any legend formatting for ClickHouse queries.

@srikanthccv
Copy link
Member

We can get this merged independent of the other changes that follow.

@vikrantgupta25 vikrantgupta25 merged commit 6af5aa0 into develop Jun 10, 2024
12 of 13 checks passed
@vikrantgupta25 vikrantgupta25 deleted the query-legend branch June 10, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

result field in table panel of dashboard always named as count
3 participants