Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added checkbox selection in dashboard variables #5191

Merged
merged 9 commits into from
Jun 18, 2024
Merged

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Jun 11, 2024

Summary

Added checkbox selection in dashboard variables

  • added only and all option for better usability

Related Issues / PR's

#4218

Screenshots

Screen.Recording.2024-06-12.at.12.28.41.PM.mov

Affected Areas and Manually Tested Areas

  • dependent nested variables ( on first load )
  • dependent nested variables chaining ( on the fly )
  • variable value storages in the local storage
  • no PUT call should happen on variable change

@SagarRajput-7 SagarRajput-7 requested a review from YounixM as a code owner June 11, 2024 19:52
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Jun 11, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 force-pushed the SIG-4218 branch 4 times, most recently from 9ba55cd to 9a96c27 Compare June 13, 2024 05:02
@SagarRajput-7 SagarRajput-7 force-pushed the SIG-4218 branch 2 times, most recently from 6af75a0 to cd24464 Compare June 13, 2024 17:40
@srikanthccv
Copy link
Member

@SagarRajput-7 functionally this LGTM. However, there is a UX issue when one value is deselected from a dropdown that has a non-trivial number of options. Imagine there are 100 operations in a service and I want to exclude tow operations. This shows the 98 other selected values in the UI which is bad. There should be a better way to handle this.
Screenshot 2024-06-13 at 10 59 01 PM

Asked a question here https://signoz-team.slack.com/archives/C03AXVC598Q/p1718299839975429

@SagarRajput-7
Copy link
Contributor Author

@SagarRajput-7 functionally this LGTM. However, there is a UX issue when one value is deselected from a dropdown that has a non-trivial number of options. Imagine there are 100 operations in a service and I want to exclude tow operations. This shows the 98 other selected values in the UI which is bad. There should be a better way to handle this. Screenshot 2024-06-13 at 10 59 01 PM

Asked a question here https://signoz-team.slack.com/archives/C03AXVC598Q/p1718299839975429

@srikanthccv - please check -

Screen.Recording.2024-06-15.at.10.56.47.PM.mov

@SagarRajput-7 SagarRajput-7 merged commit a65d509 into develop Jun 18, 2024
11 of 12 checks passed
@SagarRajput-7 SagarRajput-7 deleted the SIG-4218 branch June 18, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants