-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added checkbox selection in dashboard variables #5191
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
9ba55cd
to
9a96c27
Compare
6af75a0
to
cd24464
Compare
@SagarRajput-7 functionally this LGTM. However, there is a UX issue when one value is deselected from a dropdown that has a non-trivial number of options. Imagine there are 100 operations in a service and I want to exclude tow operations. This shows the 98 other selected values in the UI which is bad. There should be a better way to handle this. Asked a question here https://signoz-team.slack.com/archives/C03AXVC598Q/p1718299839975429 |
@srikanthccv - please check - Screen.Recording.2024-06-15.at.10.56.47.PM.mov |
…or overflowed content
Summary
Added checkbox selection in dashboard variables
Related Issues / PR's
#4218
Screenshots
Screen.Recording.2024-06-12.at.12.28.41.PM.mov
Affected Areas and Manually Tested Areas