feat: added an option to create channel when no Channels are available in alert config #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
SagarRajput-7
changed the title
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
SagarRajput-7
force-pushed
the
nochannel-handling
branch
from
cf67f69 to
6711b8e
Compare
SagarRajput-7
force-pushed
the
nochannel-handling
branch
from
5d8ccb5 to
238db76
Compare
|
Seems like the button has a box shadow, should remove that.. |
|
I don't see any role handling here. An Editor can create alerts but they can't create an alert channel, which only the admin can do. Showing the button for everyone and then failing with a forbidden error is a bad user experience. |
SagarRajput-7
force-pushed
the
nochannel-handling
branch
from
d5cff16 to
50e8069
Compare
SagarRajput-7
force-pushed
the
nochannel-handling
branch
from
50e8069 to
0858add
Compare
srikanthccv
reviewed
Jun 13, 2024
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
makeavish
approved these changes
Jun 13, 2024
…l in alert config
SagarRajput-7
force-pushed
the
nochannel-handling
branch
from
492c728 to
9128062
Compare
srikanthccv
approved these changes
Jun 13, 2024
YounixM
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / PR's
SigNoz/engineering-pod#1366
Screenshots
Screen.Recording.2024-06-12.at.3.45.22.AM.mov
Affected Areas and Manually Tested Areas