Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table row data doesn't align with the response #5248

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

vikrantgupta25
Copy link
Member

@vikrantgupta25 vikrantgupta25 commented Jun 17, 2024

Summary

  • the calculation for filling of values in the respective columns didn't account for response of the format
  • hence sorting the series order internally based on label columns concatenated on values to maintain the same order across.
  • passed the isEqualQuery from the parent to the child function as when the series with equal labels is traversed we should not fill N/A as it has already been filled by the parent row query
series A -> [ label1, label2] 

series B -> [label2, label1]

Related Issues / PR's

fixes #5228

Screenshots

before
image

after
image

Affected Areas and Manually Tested Areas

Verified here http://stagingapp.signoz.io/dashboard/a08716a3-5af6-407f-b81f-7d2f89e33d4e?relativeTime=3d&expandedWidgetId=1f3881cb-1ae1-4d13-abba-64af5feffbb0

@github-actions github-actions bot added the bug Something isn't working label Jun 17, 2024
@vikrantgupta25 vikrantgupta25 changed the title fix: wrong values getting associated with the table rows fix: table row data doesn't align with the response Jun 17, 2024
@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review June 17, 2024 08:16
@vikrantgupta25 vikrantgupta25 requested a review from YounixM as a code owner June 17, 2024 08:16
@vikrantgupta25 vikrantgupta25 merged commit 0fade42 into develop Jun 18, 2024
11 of 12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the table-panels branch June 18, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table row data doesn't align with the response
3 participants